Closed TheCount closed 1 year ago
Base: 87.72% // Head: 87.72% // No change to project coverage :thumbsup:
Coverage data is based on head (
41441c6
) compared to base (0907c3f
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
There appears to be another overflow bug:
--- FAIL: TestRuntime (0.39s)
--- FAIL: TestRuntime/lua/basic.quotas.lua (0.04s)
runtests.go:77: [output line 5, source line 44] expected: "done\t3736710778780434371", got: "done\t-980107325"
FAIL
I'll try to expand this pull request accordingly.
The problem is with runtime.Value.ToString
. Will post a fix shortly.
i noticed this too and did a fix like https://github.com/arnodel/golua/commit/fc92e663c7ad82845f7e4eddd24f0f34b7530834 on my fork
Looks good, thanks for this.
packFormatReader uses an
uint
for its option size, somaxDecuplable
must not overflowuint
. This happened on 32-bit archs and is fixed with this PR.