search

arnodelorme / mffmatlabio

MFF Matlab file importer and exporter
GNU General Public License v3.0
11 stars 16 forks source link

`pop_mffimport` vs `pop_readegimff` #1

Closed mattansb closed 4 years ago

mattansb commented 6 years ago

I've been comparing compatibility between the new pop_mffimport and the old pop_readegimff, and have come across some issues / questions regarding the EEG.event struct:

  1. What are the units of EEG.event.duration? All E-Prime events are of length 1000000. Are these samples? (milli)seconds?
  2. Breaks in recording do not appear as events (they did in pop_readegimff, as 'break cnt' events, with EEG.event.duration representing the total break in recording). Is there a way to add them?
  3. Events are not indexed into EEG.urevent (which is blank).

Hope you are able to help, and thanks for this awesome plugin!

Session Info:

mattansb commented 6 years ago

Point 2 seems to cause a major problem as it seems that event latencies in pop_mffimport do not account for these breaks, thus causing an offset that increases with every break in recording. See image below: offset

arnodelorme commented 4 years ago

Can you share a file with a break?

mattansb commented 4 years ago

Yes, this one has in the beginning https://drive.google.com/drive/folders/12SGubGunvusEkl2RcWCRI8AlSygfWnNT

arnodelorme commented 4 years ago

Hi Mattan,

The original issue was fixed some time ago.

The new matlabmffio does convert the event to boundaries but not the old plugin keeps them as "break cnt." At least this is what I observed with the file you sent me.

All is good on my side. Let me know if it is not on yours. Cheers,

Arno