search

arnog / react-mathlive

Example using the React bindings for Mathlive
19 stars 17 forks source link

react-math-view => react-mathlive (bindings and example) #5

Closed ShaMan123 closed 3 years ago

ShaMan123 commented 3 years ago

PR

OK! I hard copied all the files from react-math-view. It compiles, the example app runs.

A few things in mind

  1. I think it's best for the entire react bindings to reside here and not in mathlive - it makes more sense, is cleaner, easier to maintain and is the community convention.
  2. You should update the README.md as you wish
  3. In order to publish to npm and deploy a gh-pages web app you will need to run additional commands (listed in README.md). I've updated package.json which, I believe, is all the config it needs, but still be wary of how it behaves for the first time (I am not sure how it will behave because of the hard copy).

Issues

  1. ~The most major issue is #2 Event Bubbling. Once it is solved properly I deem react-mathlive stable. This will solve #3 or at least will enable better triage.~ FIXED

  2. 4 is important too but not breaking (if you avoid updating options during editing)

arnog commented 3 years ago

Awesome. Thanks for this wonderful contribution. I'll keep it in this separate repo, and I'll look into moving the Vue.js bindings as well, for consistency. It does make sense to have separate repos for them. I kept the Vue.js in the main depot because I was worried of forgetting to update it when necessary... I'll try to keep both depots in mind.

ShaMan123 commented 3 years ago

Happy to contribute to great work. BTW why not add some github action or publish script that will log a remainder? Or mayhap run unit test? Ping me once you've published the npm package. I'll shut down my own.