search

arnog / tecendil-js

Tengwar mode files and localization for Tecendil
https://tecendil.com
MIT License
25 stars 19 forks source link

fix(spanish.jsonc): fix ió diphthong #61

Closed icorreafalconi closed 2 years ago

icorreafalconi commented 2 years ago

By chance I wrote a word with an "ió" diphthong and I realized that the ó is being written with a double acute, not with a double right curl: image

I fixed this in the spanish.jsonc file, but I just realized something else that did not allow me to test properly. On Tecendil, if I write the double right curl on the Español mode it does not render: image

and this behavior persist on other modes (e.g Deutsch): image

but in others (e.g. English) the behavior is the correct one: image

I'm at a loss as to what is happening here, but I decided to raise the PR nonetheless to fix the small mistake and to inform you.

arnog commented 2 years ago

The tengwa "double-right-curl" had the preprocessing rules applied to it, result in "double-rright-curl", which is not a valid tengwa literal. Fixed now.

icorreafalconi commented 2 years ago

I did a ctrl+f5 con Tecendil and this happened 😢 . Now it does not apply the diphthong rule. image

heliosdrm commented 2 years ago

I did a ctrl+f5 con Tecendil and this happened cry . Now it does not apply the diphthong rule. image

The last snapshot shows English mode, not Spanish.

arnog commented 2 years ago

Right. What did you expect to happen when the english mode is selected?

icorreafalconi commented 2 years ago

God dammit! My bad.