arnohakk / DSA5-ProbeMaker

Small tool to use hero .json files created with Optolith for The Dark Eye/ Das Schwarze Auge 5 to perform talent probes.
2 stars 0 forks source link

Talent Liste mit Default Werten extern in config Datei #2

Open casibus opened 2 years ago

arnohakk commented 2 years ago

Why should we do this? If a talent is equal to zero or an attribute is eight, they are not being stored in the .json file by Opolith.

casibus commented 2 years ago

Code Style. In a class init method you do not like to have a long list of "data". Mostly for readability (both the code, as well as the "data")

arnohakk commented 2 years ago

So just move that to a separate file? There is some computation going on there still.

casibus commented 2 years ago

Hm jeah it is just not nice to have endless lines of code in the same script that contains the application flow. I will have a look at it