search

arnokeesman / Magnet-Command

Server-side Fabric mod that implements a magnet by command.
MIT License
2 stars 0 forks source link

Magnet OnBreak does not give Decorated Pot loot on 1.21 #5

Open Jarrose37 opened 1 month ago

Jarrose37 commented 1 month ago

When in the new trials and you break a pot loot drops but with this mod OnBreak loot just gets deleted and you get the pot

Vaskyy commented 1 month ago

Can confirm that. U get the pot mats, but not the loot.

arnokeesman commented 1 month ago

Interesting, does the same problem occur with opts placed by players? (I haven't touched pots or tails chambers yet) Will look into it tomorrow, way too late to dig into code now

Jarrose37 commented 1 month ago

https://streamable.com/pwymzl if ur inv is full it will delete the items in the pot

arnokeesman commented 1 month ago

ah thanks for the clarification, this probably isn't limited to pots then....

arnokeesman commented 1 month ago

following the code, I really don't have a clue what happening, its fine for other containers and everything in my limited testing this fix seems to be fine for both pots and other containers though https://github.com/arnokeesman/Magnet-Command/actions/runs/9943600796