arnoldclark / front-end-interview

MIT License
2 stars 2 forks source link

Update tasks #3

Closed johnmccollum closed 2 years ago

johnmccollum commented 2 years ago

This PR:

Rather than reading through the changes, it might be easier to browse the branch on this one. Here are the relevant files:

README: https://github.com/arnoldclark/front-end-mob-programming/tree/jm/update_tasks

Mob Programming exercise: https://github.com/arnoldclark/front-end-mob-programming/blob/jm/update_tasks/MobProgramming.md

Show And Tell exercise: https://github.com/arnoldclark/front-end-mob-programming/blob/jm/update_tasks/ShowAndTell.md

Who are we looking for? https://github.com/arnoldclark/front-end-mob-programming/blob/jm/update_tasks/WhoAreWeLookingFor.md

johnmccollum commented 2 years ago

After finishing this stuff yesterday, I came across another really interesting option online. The idea of the exercise is to provide a codebase that has a few issues in it, and allow the candidate to provide feedback on what could be improved.

Positives:

Negatives:

But as usual any thoughts would be welcome.

PrincessSarahB commented 2 years ago

I think option 3 sounds quite good - reviewing PRs is a part of everyone's job here and being able to point out mistakes or suggest improvements in a helpful way is a useful skill to assess I think.

futuresocks commented 2 years ago

I think option 3 sounds quite good - reviewing PRs is a part of everyone's job here and being able to point out mistakes or suggest improvements in a helpful way is a useful skill to assess I think.

Yeah, I agree with Sarah. I think the only pitfall with it is we don't want it to turn into a "we know the things that are wrong with this and you have to find them all" exercise, As long it stays focussed on how the applicant communicates I think there'd be real value here.

RiccardoMargiotta commented 2 years ago

After finishing this stuff yesterday, I came across another really interesting option online. The idea of the exercise is to provide a codebase that has a few issues in it, and allow the candidate to provide feedback on what could be improved.

That could be a great way to go, perhaps less intimidating than sitting straight down at the code editor. I've heard of folks doing this in a PR review kind of scenario, so it's a little more targeted to a set of file changes rather than a full codebase. Also interesting to see what people would pick up on, and how they would deliver that feedback in a helpful and constructuve way.

But also not without its problems - I suspect this works better if you're used to working in a team rather than as a solo dev.

ellie-at-arnoldclark commented 2 years ago

Friendly, easy to understand instructions, and multiple options to choose from. Looks great 👍

I think a PR review option would be quite interesting despite the issues already mentioned above.

johnmccollum commented 2 years ago

I've changed up the "Who Are We Looking For" file. Might be better, might be worse. Tough one.