search

arnoldle / phplist-plugin-inlineImagePlugin

A plugin to allow embedded inline images in list messages
2 stars 3 forks source link

Update inlineImagePlugin.php #2

Closed bst2002git closed 9 years ago

bst2002git commented 9 years ago

Some changes if image has no fully qualified url

arnoldle commented 9 years ago

I am not going to merge this pull request. Any images to be attached inline from the local file system should be accessible with an absolute URL. The task of changing a relative URL to an absolute value is in general not easy to do. See https://www.google.com/search?q=php+relative+absolute+url&ie=UTF-8&oe=UTF-8&hl=en. It is not clear to me exactly how bullet-proof the solutions on offer are. The issue with relative URLs seems to be relatively minor to me, and not worth making large, ugly changes to the code of this plugin.

bst2002git commented 9 years ago

Hello, i understand you, but if the TinyMCE saves then your script may fail. I'v configured TInyMCE to make absolute urls, but sometimes i don't know why it does not. And what i discoverd today is that if i use the plugin ViewBrowserPlugin to view the newsletter via an http-link the images are broken while .

arnoldle commented 9 years ago

Hi,

I have not tested the plugin with TinyMCE, and I have no idea of the possible interaction between that editor and my plugin.

IMO it is impossible to test all the possible interactions between other plugins and the inlineImagePlugin; that would involve and ungodly amount of work.

The only editor that I have used in testing the plugin is the fckphplistplugin distributed with Phplist. In that editor, I customarily edit the source to establish absolute links to images and to establish the correct inline class for an inline image.I do not use the visual editor to create inline images.

I have never used the plugin on a list with 150,000 subscribers, but I see no reason why the plugin should fail for that number when it works with a somewhat smaller number of subscribers.

I am sorry I cannot be more helpful, Arnold

On Apr 14, 2015, at 7:50 AM, bst2002git notifications@github.com wrote:

Hello, i understand you, but if the TinyMCE saves x-msg://9/images/upload/en/test.jpg then your script may fail. I'v configured TInyMCE to make absolute urls, but sometimes i don't know why it does not. Further i'v not tested but does your script make this on every "list member" say about 150.000 emails. And what i discoverd today is that if i use the plugin ViewBrowserPlugin to view the newsletter via an http-link the images are broken while applewebdata://C348537F-655D-439C-82ED-89E25B2CCBF0.

— Reply to this email directly or view it on GitHub https://github.com/arnoldle/phplist-plugin-inlineImagePlugin/pull/2#issuecomment-92805879.