arnoldle / phplist-plugin-submitByMailPlugin

Elements of a plugin to submit messages to Phplist by mail. In development. Planning for June release.
3 stars 6 forks source link

Footer URLs broken #14

Open dvdp opened 7 years ago

dvdp commented 7 years ago

Hi Arnold,

Just noticed a minor yet strange problem when submitting a campaign by mail. The URLs in the footer for unsubscribing, forwarding, account settings are getting escaped by extra quotes. When I use the phpList web GUI this doesn't happen.

Depending on how the mail is read (browser, outlook, ...) this produces bad URLS, e.g:

This is what I get as preferences URL when launching from the web GUI: http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= And if I use submitByMail this becomes: In my provider (telenet) webmail: https://mail.telenet.be/"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=/" and in Outlook the link looks like: /"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=\" quotes again .... Looks like when submitting by mail extra quotes are surrounding the footer URLs, this is only happening for hyperlinks in the footer(s) and not for links in the message body and not for email addresses in the footer.

br Danny

arnoldle commented 7 years ago

I am sorry to disappoint you, Danny. But if you look at https://resources.phplist.com/plugin/submitbymail https://resources.phplist.com/plugin/submitbymail , you will see that I am no longer active in Phplist development and no longer actively support the plugin.

If someone else would wish to support the plugin, I would gladly consult with him or her to bring that person up to speed.

Sorry. Arnold

On Sep 28, 2016, at 9:39 AM, dvdp notifications@github.com wrote:

Hi Arnold,

Just noticed a minor yet strange problem when submitting a campaign by mail. The URLs in the footer for unsubscribing, forwarding, account settings are getting escaped by extra quotes. When I use the phpList web GUI this doesn't happen.

Depending on how the mail is read (browser, outlook, ...) this produces bad URLS, e.g:

This is what I get as preferences URL when launching from the web GUI: http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= And if I use submitByMail this becomes: In my provider (telenet) webmail: https://mail.telenet.be/"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= https://mail.telenet.be/%22http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=/" and in Outlook the link looks like: /"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=\" quotes again .... Looks like when submitting by mail extra quotes are surrounding the footer URLs, this is only happening for hyperlinks in the footer(s) and not for links in the message body and not for email addresses in the footer.

br Danny

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/arnoldle/phplist-plugin-submitByMailPlugin/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqj-1jDOl9amkwpiNbMtNFsmvQQGjkTks5qunw9gaJpZM4KI6EP.

dvdp commented 7 years ago

Hi Arnold,

Sorry to hear that - SubmitByMail is by far my favorite phpList plugin. I guess I'll have to dig in the code myself next time some incompatibilities arise with phpList and/or php updates. If there's any info you can share that could be of help whenever changes are needed, I would be very grateful. I'm afraid taking over support is not quite inline with my level of PHP/Joomla expertise and most of all, I don't have a suitable debugging environment.

For what it's worth: I solved the thing with the quotes: those were simply in my footer settings - odd since I just used the default and translated to Dutch.

br Danny

----- Oorspronkelijk bericht -----

Van: "arnoldle" notifications@github.com Aan: "arnoldle/phplist-plugin-submitByMailPlugin" phplist-plugin-submitByMailPlugin@noreply.github.com Cc: "dvdp" danny.vandepol@telenet.be, "Author" author@noreply.github.com Verzonden: Dinsdag 4 oktober 2016 18:09:04 Onderwerp: Re: [arnoldle/phplist-plugin-submitByMailPlugin] Footer URLs broken (#14)

I am sorry to disappoint you, Danny. But if you look at https://resources.phplist.com/plugin/submitbymail https://resources.phplist.com/plugin/submitbymail , you will see that I am no longer active in Phplist development and no longer actively support the plugin.

If someone else would wish to support the plugin, I would gladly consult with him or her to bring that person up to speed.

Sorry. Arnold

On Sep 28, 2016, at 9:39 AM, dvdp notifications@github.com wrote:

Hi Arnold,

Just noticed a minor yet strange problem when submitting a campaign by mail. The URLs in the footer for unsubscribing, forwarding, account settings are getting escaped by extra quotes. When I use the phpList web GUI this doesn't happen.

Depending on how the mail is read (browser, outlook, ...) this produces bad URLS, e.g:

This is what I get as preferences URL when launching from the web GUI: http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= And if I use submitByMail this becomes: In my provider (telenet) webmail: https://mail.telenet.be/"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= https://mail.telenet.be/%22http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=/" and in Outlook the link looks like: /"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=\" quotes again .... Looks like when submitting by mail extra quotes are surrounding the footer URLs, this is only happening for hyperlinks in the footer(s) and not for links in the message body and not for email addresses in the footer.

br Danny

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/arnoldle/phplist-plugin-submitByMailPlugin/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqj-1jDOl9amkwpiNbMtNFsmvQQGjkTks5qunw9gaJpZM4KI6EP.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

arnoldle commented 7 years ago

I’m glad you were able to find a fix for the problem. From the nature of the problem and the lack of any other questions about the issue, it did not sound like SBM was responsible. But not having worked with Phplist or the SBM plugin for some time now, I could not be sure.

What you might do on the question of support of the plugin is to post to phplist-developers@lists.sourceforge.net to see whether there might be someone willing to take over the support. Good luck!

Arnold

On Oct 5, 2016, at 1:53 AM, dvdp notifications@github.com wrote:

Hi Arnold,

Sorry to hear that - SubmitByMail is by far my favorite phpList plugin. I guess I'll have to dig in the code myself next time some incompatibilities arise with phpList and/or php updates. If there's any info you can share that could be of help whenever changes are needed, I would be very grateful. I'm afraid taking over support is not quite inline with my level of PHP/Joomla expertise and most of all, I don't have a suitable debugging environment.

For what it's worth: I solved the thing with the quotes: those were simply in my footer settings - odd since I just used the default and translated to Dutch.

br Danny

----- Oorspronkelijk bericht -----

Van: "arnoldle" notifications@github.com Aan: "arnoldle/phplist-plugin-submitByMailPlugin" phplist-plugin-submitByMailPlugin@noreply.github.com Cc: "dvdp" danny.vandepol@telenet.be, "Author" author@noreply.github.com Verzonden: Dinsdag 4 oktober 2016 18:09:04 Onderwerp: Re: [arnoldle/phplist-plugin-submitByMailPlugin] Footer URLs broken (#14)

I am sorry to disappoint you, Danny. But if you look at https://resources.phplist.com/plugin/submitbymail https://resources.phplist.com/plugin/submitbymail , you will see that I am no longer active in Phplist development and no longer actively support the plugin.

If someone else would wish to support the plugin, I would gladly consult with him or her to bring that person up to speed.

Sorry. Arnold

On Sep 28, 2016, at 9:39 AM, dvdp notifications@github.com wrote:

Hi Arnold,

Just noticed a minor yet strange problem when submitting a campaign by mail. The URLs in the footer for unsubscribing, forwarding, account settings are getting escaped by extra quotes. When I use the phpList web GUI this doesn't happen.

Depending on how the mail is read (browser, outlook, ...) this produces bad URLS, e.g:

This is what I get as preferences URL when launching from the web GUI: http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= And if I use submitByMail this becomes: In my provider (telenet) webmail: https://mail.telenet.be/"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= https://mail.telenet.be/%22http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=/" and in Outlook the link looks like: /"http://www.sint-jozefekeren.be/phpList/?p=preferences&uid= http://www.sint-jozefekeren.be/phpList/?p=preferences&uid=\" quotes again .... Looks like when submitting by mail extra quotes are surrounding the footer URLs, this is only happening for hyperlinks in the footer(s) and not for links in the message body and not for email addresses in the footer.

br Danny

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/arnoldle/phplist-plugin-submitByMailPlugin/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqj-1jDOl9amkwpiNbMtNFsmvQQGjkTks5qunw9gaJpZM4KI6EP.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arnoldle/phplist-plugin-submitByMailPlugin/issues/14#issuecomment-251596534, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqj-9pKQsec9-I1M_M3kxQjA5F3ZIwaks5qw0lugaJpZM4KI6EP.