arnoob16 / GeeksForGeeksAPI

Unofficial GeeksForGeeks API
https://geeks-for-geeks-api.vercel.app/arnoob16
59 stars 19 forks source link

Improve generalInfo extraction #8

Closed shaileshaanand closed 2 years ago

shaileshaanand commented 2 years ago

This PR improves generalInfo extraction logic to prevent crashes for some profiles

Example:

This PR introduces order independent searching for data so even if more fields are added to .userMainDiv the extraction will not stop.

fixes #7

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arnoob16/geeks-for-geeks-api/GdubYW3wCxJCkEMUJryenmW1LVbg
✅ Preview: https://geeks-for-geeks-api-git-fork-shaileshaanand-extraction-arnoob16.vercel.app

shaileshaanand commented 2 years ago

Hey, thank you for solving this bug, I've reviewed it and it works nice. Just make an issue in the issues tab and link this PR to that issue, I'll merge it then.

@arnoob16 Issue Already exists (#7), I have linked to it