search

arnoson / kirby-vite

Use Kirby CMS together with Vite
MIT License
81 stars 7 forks source link

Type hints and enhancements #34

Closed bogdancondorachi closed 1 year ago

bogdancondorachi commented 1 year ago

Hello, I've added some small improvements as explained below:

  1. Added appropriate type hints that provide clear documentation for the methods' expected inputs and outputs
  2. Instead of using strpos, we use str_starts_with, which is more concise
  3. Added support for Less and Stylus and used in_array for the $entryIsStyle

Edit: For some reason I get 'The system cannot find the path specified.' when trying to run tests on local

arnoson commented 1 year ago

Thanks for the PR! Not sure why the test are failing locally (I'm using ubuntu via WSL2) and can run them.

arnoson commented 1 year ago

If you wan't to appear in the release message you can use conventional commits in your PRs (I edited this release message manually to include you). Thanks again for the contribution :)