search

arnoudkooi / sn-scriptsync

Use sn-scriptsync in combination with SN Utils to be able to code in VS Code, including all benefits of a full fledged code editor
https://marketplace.visualstudio.com/items?itemName=arnoudkooicom.sn-scriptsync
Other
43 stars 28 forks source link

Correcting a typo in the naming of the sp_header_footer files created #95

Closed mitchfleisch closed 5 months ago

mitchfleisch commented 5 months ago

For consistency, so the sp_header_footer files match the names of the files created with sp_widget.

arnoudkooi commented 5 months ago

Thanks, but I'm only accepting pre aligned PR's and no typo PR's as explained in the SN Utils contributing guideline. For clarity, I'll reference those hear more explicit in a next update.

mitchfleisch commented 5 months ago

This has an impact on the files created on the user’s computer, and not a typo per-se. I have a PowerShell script that converts the pre-version 3 naming convention for the files to the version 3+, and the sync script creates a “client_cript.js” file, which must be manually changed to the correct “client_script.js” for any changes to be sent back to the instance. This PR would prevent the user from needing to manually change the name of the file for the changes made in VS Code to be saved to the instance. Apologies for not reviewing the contribution guidelines - can you post a link?

arnoudkooi commented 5 months ago

Ok, thanks for clarifiying, I just published 3.3.3 containing the fix. Thanks!