arnoutaertgeerts / python-highcharts

Use highchart.js to make plots in Python and IPython notebooks
http://nbviewer.ipython.org/github/arnoutaertgeerts/python-highcharts/blob/master/Tutorial.ipynb
Other
134 stars 31 forks source link

All data in series object is plotted, regardless of the 'display' value #13

Closed matsvandecavey closed 9 years ago

matsvandecavey commented 9 years ago

When creating a 'series' object, with display=True for a subset of variables, this value is overwritten to True for all variables in by charts.plot(series). The dataframe.ipynb ipython notebook shows this behaviour. It now plots all variables, not only the ones with 'display'=True.

arnoutaertgeerts commented 9 years ago

@matsvandecavey I changed this behavior in the new version (0.2.0). You know have to specify which variables to plot in the plot() method instead of setting the display property in the dictionary. You have three options:

Furthermore, you don't have to convert the dataframe to a series object anymore. You can just do:

plot(df, options, display=['A', 'Z']

I think you can see an example in the Different series type notebook.

matsvandecavey commented 9 years ago

Should you then leave out the option to change the 'display' modifier in the low level df_to_series? and/or leave out the dataframe.ipynb example?

arnoutaertgeerts commented 9 years ago

@matsvandecavey The function df_to_series() in the data module actually became obsolete and never has to be called by the user. It is replaced by the df_to_series() function in the core module.

Now if you want to plot a dataframe you can just do: plot(df).

arnoutaertgeerts commented 9 years ago

I assume this is ok like this?