search

arnowelzel / lightbox-photoswipe

Integration of PhotoSwipe to WordPress
https://arnowelzel.de/wp/en/projects/wordpress/lightbox-with-photoswipe
GNU General Public License v2.0
27 stars 7 forks source link

Missing alt tag in lightbox img #21

Closed C0pyR1ght closed 4 years ago

C0pyR1ght commented 4 years ago

Hi Arno,

I appreciate the hard work you put into this and the frequent updates you provide. We are currently putting some effort in SEO-optimizing our site. In the course of that we discovered a missing alt-tag for the image that opens inside the lightbox even though the alt-tag on the original image is set.

<img class="pswp__img" src="/path/to/img.jpg" style="display: block; width: 473px; height: 473px;">

arnowelzel commented 4 years ago

Thanks for pointing this out. I'll fix this for the next update.

arnowelzel commented 4 years ago

Fixed with 7d1cac173393a5c8da2c4475b6ffb176150f837c

Just a note: since the images in the lightbox are only created dynamically when opening it no search engine will ever see this.

C0pyR1ght commented 4 years ago

great, thanks for the quick reply

Just a note: since the images in the lightbox are only created dynamically when opening it no search engine will ever see this.

didn't knew that. But that explains why lighthouse audit didn't point this out.