search

arnowelzel / lightbox-photoswipe

Integration of PhotoSwipe to WordPress
https://arnowelzel.de/wp/en/projects/wordpress/lightbox-with-photoswipe
GNU General Public License v2.0
27 stars 7 forks source link

Feature: Support for Photoswipe API #55

Closed tbiering closed 4 years ago

tbiering commented 4 years ago

As discussed in issue #54, this PR adds support for the Photoswipe API by creating a global variable "lbwpsPhotoSwipe" to allow interaction with the JavaScript object.

arnowelzel commented 4 years ago

Sorry for the confusion - I also added this already during refactoring - you where too fast ;-)

tbiering commented 4 years ago

No problem, just one more suggestion: I added a "How to use the PhotoSwipe API" chapter to the readme which is missing on your update. I think this (or similar) would be a worthwhile addition for people searching about how to extend the plugin.

Thanks for the quick update on the plugin!

arnowelzel commented 4 years ago

I just added the FAQ entry about the API with https://github.com/arnowelzel/lightbox-photoswipe/commit/d84113c5798a840f5e0d27f8017683b64a862e80.