Fix bugs in generated pkgconfig file

hedgepigdaniel commented 3 years ago

Hello, these are some fixes that I made to use this project as a dependency using meson (i.e. through pkgconfig):

Update jrl-cmakemodules which includes https://github.com/jrl-umi3218/jrl-cmakemodules/pull/335
use the new PKG_CONFIG_REQUIRES to cause eigen3 to be included in the Requires line of the generated pkgconfig. This is necessary so that the include directives for Eigen headers work (their include path is non standard).
use pkg_config_append_libs to ensure that -lgram_savitzky_golay is included in the Libs line of the generated pkgconfig. This is necessary so that the exported symbols are available to the linker.

hedgepigdaniel commented 3 years ago

My motivation is to remove the patches from this: https://aur.archlinux.org/packages/gram-savitzky-golay-git/

arntanguy commented 3 years ago

The CI issue should hopefully be resolved. This was due to Microsoft removing Boost from the virtual environments for windows and ubuntu. Cf: https://github.com/actions/virtual-environments/issues/2667. We've updated our github actions accordingly.

arntanguy / gram_savitzky_golay

Fix bugs in generated pkgconfig file #8