search

arobase-che / remark-attr

Remark plugin to add support for custom attributes
Other
58 stars 16 forks source link

Replace object spread with Object.assign #5

Closed Hypercubed closed 5 years ago

Hypercubed commented 5 years ago

The object spread operator is not currently supported in MS Edge (I know :( ). That makes any site I build that includes remark-attr crash on Edge. I'm hesitant to submit this PR because it should be something I can handle in my build pipe... but I'm having no luck with Angular CLI... which can be pretty opinionated in its build process.

I know it is ugly but would appreciate this change... Thanks.

arobase-che commented 5 years ago

Yeah, i understand the problem.

Let's make a transpiling solution based on babel.

Oh and about fencedCode, everything is ready in remark-parse to support the feature. I'm waiting for a new version of remark-parse to delete that weird hack in the code.

Hypercubed commented 5 years ago

It's been a while since I touched babel... maybe TS?

Do you think we can merge this while we wait for a babel version?

arobase-che commented 5 years ago

Humm, what about the v0.7.1 ?

It should work better now on edge.

Hypercubed commented 5 years ago

Perfect! Thank you again!