arobenko / embxx

embxx - Embedded C++ Library
GNU General Public License v3.0
263 stars 36 forks source link

CompilerOptionsFuncs.cmake - Unix conditions #2

Closed 0xc0170 closed 8 years ago

0xc0170 commented 8 years ago

Why many macros in the CompilerOptionsFuncs cmake contain condition if (UNIX) ? Is there any intention?

An example:

macro (embxx_disable_exceptions)
    if (UNIX)
        embxx_add_cxx_flags("-fno-exceptions -fno-unwind-tables")
    endif ()
endmacro ()

I would like to remove that UNIX, because I don't think those flags contain anything specific for UNIX. I'll send PR shortly removing it from there

arobenko commented 8 years ago

See response in #4

arobenko commented 8 years ago

Merged to "develop" branch. Use "develop" branch in "embxx_on_rpi" project as well.