search

arobenko / embxx

embxx - Embedded C++ Library
GNU General Public License v3.0
262 stars 35 forks source link

Compiler options - remove unix conditions #4

Closed 0xc0170 closed 8 years ago

0xc0170 commented 8 years ago

Those flags shall be cross-platform, thus if (UNIX) was removed.

This is an attempt to fix #2

arobenko commented 8 years ago

These are g++ related options. My intention was to make sure that the right options with the right meaning are passed to the compiler being used. I've developed using gcc on Linux system. At that time I haven't thought that someone will use gcc on Windows systems. The condition should not be removed, just replaced with CMAKE_COMPILER_IS_GNUCC instead of UNIX.

0xc0170 commented 8 years ago

The condition should not be removed, just replaced with CMAKE_COMPILER_IS_GNUCC instead of UNIX.

Yes, I'll rebase it, and replace it.

0xc0170 commented 8 years ago

Replaced, and rebased. Compiles for me with this changeset, please test

arobenko commented 8 years ago

Merged to "develop" branch.