aroberge / reeborg

Enhanced Karel-the-robot clone
http://reeborg.ca/reeborg.html
Other
47 stars 36 forks source link

Editor/Library content dialog appears below editor #362

Closed aroberge closed 7 years ago

aroberge commented 7 years ago

When a world include some content for the editor/library, the dialog offering to use this content to replace that currently in the editor/library appears below the code editor.

aroberge commented 7 years ago

Thinking some more about this situation ...

When a user clicks on the button to replace the content, they lose the previous content, which might often be undesireable, especially while working towards a solution.

After much reflexion (and practical use), I think it would be preferable to NOT have the possibility to include content from the editor or the library (but blockly would be ok), and to write instead the relevant code in the description editor, giving the possibility of copy/paste the relevant parts in the editor or library, as the user prefers.

aroberge commented 7 years ago

I'm reopening this issue ... as I think that, while the new default to prevent offering code to be copied makes sense, it still might be worthwhile having a function, like RUR.copy_code(editor, library) to be available from the onload editor. To deal with the hidden dialog, one option might be to open it on top of the world instead of on top of the editor.