search

aroberge / reeborg

Enhanced Karel-the-robot clone
http://reeborg.ca/reeborg.html
Other
47 stars 36 forks source link

Translation problem with blockly on reeborg-staging #442

Open aroberge opened 6 years ago

aroberge commented 6 years ago

When using the version on reeborg-staging, the loop information on two blocks (while and break/continue) is only displayed in Chinese - never updated to other languages.

aroberge commented 6 years ago

This appears to be an issue with Blockly, which I reported. See https://github.com/google/blockly/issues/1964 for details.

aroberge commented 6 years ago

I don't really like the suggestions offered on https://github.com/google/blockly/issues/1964: reloading the page would be an annoyance to the users and should not be warranted; the other method would likely require me to build my own blocks with their tools.

What I plan to do instead is go back to their implementation of these blocks before they switch to JSON definitions [1], and incorporate the small amount of Javascript code in my existing blocks definitions [2]

[1] For example: https://github.com/google/blockly/blob/edd3e3bf3350e15f8d34435216c80f19f022401d/blocks/loops.js

[2] https://github.com/aroberge/reeborg/blob/master/src/js/programming_api/blockly.js