cleanup docker container after kill

arobson / rabbot

Deprecated: Please see https://github.com/Foo-Foo-MQ/foo-foo-mq

MIT License

277 stars 129 forks source link

cleanup docker container after kill #130

Closed alonisser closed 6 years ago

alonisser commented 6 years ago

On dev:

Currently running


npm run start-container
npm run stop-container

npm run start-container # (again)

Would fail the second run since kill does not clean the existing container A cleanup should remove container after kill

arobson commented 6 years ago

@alonisser - just a heads up that I did make a slight change after accepting your PR. Calling a command named stop-container and having it removed could be really irritating to someone who was expecting to be able to start it back up.

I updated the section in HOW_TO_CONTRIBUTE to show the changed commands. I also added a bootstrap-container to go along with the same line of thinking.

Thanks!