search

arobson / rabbot

Deprecated: Please see https://github.com/Foo-Foo-MQ/foo-foo-mq
MIT License
277 stars 129 forks source link

fix retrival of CA from caPaths #196

Closed ugo-buonadonna closed 4 years ago

ugo-buonadonna commented 5 years ago

There's a bug where the TLS certificates are not correctly assigned to a this.options.ca variable. This is preventing rabbot to correctly instantiate a TLS connection to a server.

This PR fix this

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.08%) to 89.038% when pulling 379abaf69369635f0005adabcc3d8b0d3bb322f8 on ugo-buonadonna:master into 80b63c08bdb32d04fd36502f24180e0c8e8f69ee on arobson:master.

soumendrak commented 4 years ago

Why nobody is accepting PRs?

ebusho commented 4 years ago

Hi, @arobson , I know you're probably busy, but i hope you'll take a quick look at this minor fix (but has a major impact on security), and accept this PR.

Best Regards! Ebu

zlintz commented 4 years ago

I am maintaining a fork of rabbot, and I am fixing this issue over here at https://github.com/Foo-Foo-MQ/foo-foo-mq/pull/10

auroq commented 4 years ago

The issue has been merged over at our fork that @zlintz mentioned. Foo-Foo-MQ#10

We'd love to have pull requests like this over there if you're willing to migrate. :)

zlintz commented 4 years ago

This is now released in our fork foo-foo-mq:4.0.2