fix: amqps protocol when using uri

arobson / rabbot

Deprecated: Please see https://github.com/Foo-Foo-MQ/foo-foo-mq

MIT License

277 stars 129 forks source link

fix: amqps protocol when using uri #91

Closed hugocortes closed 6 years ago

hugocortes commented 7 years ago

Hey guys, this is my first open source contribution 😄

I had an issue where passing in a rabbitmq URI that uses amqps is defaulted to amqp. Current workaround is to use the following connection settings:

  connection: {
    uri: RABBITMQ_URI,
    protocol: url.parse(RABBITMQ_URI).protocol,
    ...
  }

I did a quick test with amqp and amqps server and both successfully connected without protocol attribute.

coveralls commented 6 years ago

Coverage decreased (-0.02%) to 89.076% when pulling 5054f7b0a84a11bacc2e1aae1bbd20d5f5a07212 on hugocortes:master into 96da23f56da09bae00be2cbb93c2cc9bea39df57 on arobson:v2.