search

arobson / rabbot

Deprecated: Please see https://github.com/Foo-Foo-MQ/foo-foo-mq
MIT License
277 stars 129 forks source link

Use bluebird for promises to resolve issues with CLS #94

Closed mrfelton closed 6 years ago

mrfelton commented 7 years ago

Currently Rabbot uses the When promise library. This is known to break things that use CLS or CLS Hooked such as https://github.com/strongloop/loopback-context.

Other promise libraries such as Bluebird do not have these issues.

Either this module should use Bluebird for it's promises, it should use global.Promise, or (preferably) it should allow the user to determine which promise library is used.

ptusch commented 7 years ago

Bump Would love this feature as well. :)

weyert commented 6 years ago

This would indeed be a lovely addition to the library!

arobson commented 6 years ago

@mrfelton @ptusch @weyert For now I've just dropped back to native Promises since v2 supports Node 6 and 8 (not supporting 4 anymore).

This shouldn't break anything else but if there's a very compelling reason, I will look at adding a dependency back to it. I've tried to strip down/simplify rabbot's dependency tree considerably (and might continue to).