Changed `affected-vars` function to work with newer versions of `clojure.tools.namespace`.

aroemers / mount-lite

mount, but different and light

https://cljdoc.org/d/functionalbytes/mount-lite/

Eclipse Public License 1.0

102 stars 8 forks source link

Changed `affected-vars` function to work with newer versions of `clojure.tools.namespace`. #26

Closed titonbarua closed 3 years ago

titonbarua commented 3 years ago

Works with clojure.tools.namespace >= 0.3.
The function now uses scan-dirs instead of deprecated scan, whenever it can.
Properly accounts for reloading if refresh-dirs is set with clojure.tools.namespace.repl/set-refresh-dirs function.
Note that with newer versions of tools.namespace, setting refresh-dirs is mandatory in some cases like this: clojure-emacs/cider#2686

aroemers commented 3 years ago

Hi Titon,

I like it, thanks for this! Could you update the docstring of the refresh namespace that it also works with tools.namespace 0.3? And could you add an extra test profile that has tools.namespace 0.3 as a dependency?

titonbarua commented 3 years ago

Thank you for quick feedback! I added two new commits, implementing your requests.

By the way, I am using mount-lite to manage and gracefully reload states inside the most significant peace of software in our company. Keep up the good work!

aroemers commented 3 years ago

Released as 2.2.1. Sorry for the delay in merging this. Once again, thanks for the PR.