arogachev / yii2-sortable

Sortable ActiveRecord for Yii 2 framework
Other
17 stars 9 forks source link

add customize baseUrl and confirmation flag #25

Closed Hector68 closed 8 years ago

Hector68 commented 8 years ago

done

arogachev commented 8 years ago

Thanks! But I think it's not good idea to mix new feature implementation and code style fixes in the same PR.

Could you please revert it back to function() { for functions and { property: value } for one-liner objects with one value? And I will merge it and add info to the docs.

arogachev commented 8 years ago

If you are busy, I can do it in separate commit, but a bit later.

arogachev commented 8 years ago

Hector68 wants to merge 2 commits into arogachev:master from Hector68:master

Please create separate branch for PR.

Hector68 commented 8 years ago

I has created separate branch and new set new PR.

arogachev commented 8 years ago

Merged related PR: https://github.com/arogachev/yii2-sortable/pull/26