The Astropy convention makes the original code look strange: in the return statement, a speed in m/s divided by a wavelength in meters should give a result in Hertz, not THz.
Now, the original code works fine (because only the units of the result are fully taken seriously), but the proposed change makes the code look more correct and thus raises fewer questions.
The Astropy convention makes the original code look strange: in the return statement, a speed in m/s divided by a wavelength in meters should give a result in Hertz, not THz. Now, the original code works fine (because only the units of the result are fully taken seriously), but the proposed change makes the code look more correct and thus raises fewer questions.