ovhpa
commented
5 years ago Here are the statistics of the correction I made on clang bugs (total 152 bugs):
- Dead store
- Dead assignment 84
- Dead increment 2
Most of these bugs are unimportant such as:
//some code
i=0;/*i is set but lost as the next instruction re-set it*/
for(i=0;i<N;i++){
//some codeor places where some value is set but never read:
void function(){
int i;
//some code
i=0;/*i is set but lost as the function return*/
return;
}Even though there is no gain in removing them, I did it for the clean-up ;)
- Logic error
- Assigned value is garbage or undefined 7
- Branch condition evaluates to a garbage value 1
- Dereference of null pointer 11
- Dereference of undefined pointer value 6
- Result of operation is garbage or undefined 5
- Uninitialized argument value 9
Some of these bugs have require quite some change but in most cases they resolve to an unprobable case in which someone is trying to feed corrupt or unrelated data into a function.
- Memory error Memory leak 22 Use of zero allocated 3 Use-after-free 2
These where actually mostly some memory cleaning bugs (missing g_free).
arohl
Dear Prof. Rohl,
I have recently been using clang static analysis tool to remove some bugs. Even though most of these bugs didn't affect the normal operation of GDIS, I feel there have been some improvement in stability and speed after that (but that might actually be only my imagination).
Sincerely,