Add XCrySDen xsf file reader and writer

arohl / gdis

A visualization program for the display, manipulation, and analysis of isolated molecules and periodic structures

GNU General Public License v2.0

43 stars 17 forks source link

Add XCrySDen xsf file reader and writer #52

Open cajfisher opened 2 years ago

cajfisher commented 2 years ago

Adds functionality for xsf format files, including animation files, used by XCrySDen, aenet, and other packages.

ovhpa commented 2 years ago

Hi, I will review the XCrysDen file reader on this PR.

[x] gcc and other compilers (icc, clang)
[x] valgrind / libasan memory checks
[x] static analysis
[x] review

ovhpa commented 1 year ago

Hi, I finish reviewing, and almost everything looks OK. I have just one little problem: On animation, usually, I can turn the system to any orientation and the animation will be displayed given that point of view (POV), for ex: ex_00

However, when doing an animation of a xsf file, the orientation is reset at the first new frame displayed. For ex: ex01 Or in the ZnS case: ex02

Do you think you can fix that?

Best,