search

arokem / python-matlab-bridge

A simple Python => MATLAB(R) interface and a matlab_magic for ipython
BSD 2-Clause "Simplified" License
335 stars 96 forks source link

Add dependencies to setup.py #268

Open lexngu opened 8 months ago

lexngu commented 8 months ago

When installing python-matlab-bridge via pip install (or even as part of a requirements file), the installation process fails due to missing packages pyzmq and numpy.

I'd like to propose to add following line to setup.py:

# ...
opts = dict(name=NAME,
            maintainer=MAINTAINER,
            maintainer_email=MAINTAINER_EMAIL,
            description=DESCRIPTION,
            long_description=LONG_DESCRIPTION,
            url=URL,
            download_url=DOWNLOAD_URL,
            license=LICENSE,
            classifiers=CLASSIFIERS,
            author=AUTHOR,
            author_email=AUTHOR_EMAIL,
            platforms=PLATFORMS,
            version=VERSION,
            packages=PACKAGES,
            package_data=PACKAGE_DATA,
            requires=REQUIRES,
            extras_require=EXTRAS_REQUIRE,
            scripts=BIN,
            install_requires=['numpy', 'pyzmq'], # <--- new line
            )
# ...

Is this possible?

arokem commented 8 months ago

Certainly. Could you please propose this change as a pull request?

lexngu commented 8 months ago

Thanks for your quick response! Could you please update your package in PyPI, too?