[Android Boocamp] Project 4 Twitter Client - Request to review

[arolan]

Hello Nathan,

I have finished all following user stories from the assignment/project 4 for Android Bootcamp. My app is complete.

User Stories:

Includes all required user stories from Week 3 Twitter Client
User can switch between Timeline and Mention views using tabs.
    User can view their home timeline tweets.
    User can view the recent mentions of their username.
    User can scroll to bottom of either of these lists and new tweets will load ("infinite scroll")
User can click icon on Action Bar to view their profile
    User can see picture, tagline, # of followers, # of following, and tweets on their profile.
User can click on the profile image in any tweet to see that user's profile.
    User can see picture, tagline, # of followers, # of following, and tweets of clicked user.
    Profile should include that user's timeline
Optional: When a network request goes out, user sees an indeterminate progress indicator

Can you please review it? Thank you in advance!

Best, Rolan

/cc @nesquena @timothy1ee

[nesquena]

:+1: nice work overall. A few notes after checking out the code:

• Nice job with including progress bar support
• For tabs, try following this approach for cleaner tab listeners and better memory management.
• In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
• For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we covered the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Nov 11th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.