search

aromaa / WorldGuardExtraFlags

Extension for the WorldGuard plugin.
https://www.spigotmc.org/resources/worldguard-extra-flags.4823
MIT License
90 stars 71 forks source link

Add flag to do action bar messages when entering and leaving regions #87

Open espidev opened 5 years ago

espidev commented 5 years ago

Hey,

I would like to request 2 flags: greeting-action and farewell-action, which would work similarly to the existing WG flags greeting and farewell, which show a message when a player enters and leaves a region, except this would show up as an action bar. I'm not totally familiar with the source code of this plugin, but if you want I can attempt to PR with the added flag.

Thanks

aromaa commented 5 years ago

People have asked the same for titles but to keep it simple I have told them to use console-command-on-entry and exit flags to keep it simple for the plugin code base. Action bars can also be send using commands too so I would prefer it to be that way...

Also the fact that action bars and titles have limited API on older versions of Spigot is one thing that complicates things. The current maven project set up is terrible for multi spigot version support because spigot specific files are still found in Common. And at some point I also would like to add Sponge support.

Anyway, if you are down to make PR I will happily review it and try to get it merged

espidev commented 5 years ago

In terms of the titles, they have actually been added to WorldGuard 7 (greeting-title, farewell-title).

I will see if I can get this working, and will PR if I'm successful

espidev commented 5 years ago

Is there a reason you don't wrap FlagValueChangeHandler instead? It could simplify a lot of the code in entry and exit flags. I assume it might be WG 6 compatibility?