search

aromajoin / controller-http-api

The documentation for HTTP API interacting with Aroma Shooter (second generation)
2 stars 4 forks source link

Get firmware information unsafe value #5

Closed Ekristoffe closed 3 years ago

Ekristoffe commented 3 years ago

Hello, Get firmware information will return unsafe value when there is no internet connection available. In that case, a random value is assigned to the "latest" key. If possible an empty string or a predefined value should be returned. (Json parser may crash depending on the returned value)

hanhdt commented 3 years ago

Thanks for your suggestion @Ekristoffe. I'm on this issue.

hanhdt commented 3 years ago

Hi @Ekristoffe,

I just wanted to notify you about this issue which had been updated in the latest firmware version 2.0.4. You can install it via OTA update.

Ekristoffe commented 3 years ago

Fixed in 2.0.4 (Ps do you have any release note somewhere ?)

hanhdt commented 3 years ago

Thanks for reviewing. We had release notes but it's not in a public repo.