search

aromajoin / material-showcase-ios

✨ An elegant way to guide your beloved users in iOS apps - Material Showcase.
https://aromajoin.com/
Other
363 stars 128 forks source link

didTapTarget Incorrectly false for UITableViewCell #113

Open poisondminds opened 5 years ago

poisondminds commented 5 years ago

It seems that the delegate's showCaseDidDismiss?(showcase: didTapTarget:) is incorrectly false when dismissing the showcase by tapping the target cell.

tdle94 commented 5 years ago

Can you pull from master and try again. I fix the issue

poisondminds commented 5 years ago

@tdle94 it seems that your commit caused several problems - isTapRecognizerForTargetView no longer functions properly. Play with the flag in the sample app and you'll see what's broken

isTapRecognizerForTargetView set to false no longer functions as it should. When this is set to false, the showcase should dismiss when you tap outside of the target

quangctkm9207 commented 5 years ago

I just reverted to the previous commit.