search

aromajoin / material-showcase-ios

✨ An elegant way to guide your beloved users in iOS apps - Material Showcase.
https://aromajoin.com/
Other
362 stars 128 forks source link

How to increase the radius of colored background circle especially for iPads? #116

Closed pathaderavi-zz closed 3 years ago

pathaderavi-zz commented 4 years ago

I am trying to increase the size of the showcase to fit the device like it appears on iPhones but unable to find right option for that. Simulator Screen Shot - iPad Pro (12 9-inch) (3rd generation) - 2019-10-23 at 10 55 25

I am trying to stretch the blue circle in the screenshot to be fit to the screen like it appears on the iPhone or at least be able to modify the size of it.

Thank You :)

quangctkm9207 commented 4 years ago

Hi @pathaderavi,

The background radius for the iPad currently is fixed at 300. https://github.com/aromajoin/material-showcase-ios/blob/3fc0c0441a10e65b0c3b7206dd7e496824d1d4af/MaterialShowcase/MaterialShowcase.swift#L319

vmykha commented 4 years ago

Hi @quangctkm9207 , when are you going to fix this issue?

quangctkm9207 commented 4 years ago

I am working on this.

quangctkm9207 commented 4 years ago

Please check the 0.7.1 version that you can change the background radius.

acali18 commented 4 years ago

I updated to version 0.7.1 and found that the background radius can now easily be adjusted with the backgroundRadius property. Thank you.

This leaves me with 1 more question, can the location of the text from the center be adjusted as well? Changing the background radius appears to have no regard for the location of the primary and secondary text. Let me know if I'm missing something, thanks!

ppamorim commented 4 years ago

@acali18 I found that too, the text sometimes is no in the center of the radius, almost touching the outside border.

quangctkm9207 commented 4 years ago

I re-opened to fix this issue. By initial checking the codes, it seems to be more complicated than I thought.

ppamorim commented 4 years ago

@quangctkm9207 Hi, any idea how to solve this?

bug

ppamorim commented 4 years ago

I cannot solve it accessing the subviews because you implemented the addView inside the layoutSubviews, my settings are getting replaced because you unnecessarily rebuild the UILabels for no reason.

ezefire commented 4 years ago

Hi, I have the same problem of @ppamorim

quangctkm9207 commented 4 years ago

I feel so sorry that the issue is more complicated than I thought. And recently, I still don't find time to fix this one.

hamzashahid91 commented 4 years ago

@ppamorim increasing the background radius fixed it for me showcase.backgroundRadius = 400.0

SmiliPRO commented 4 years ago

Hi all! I would like to jump onto this issue. I have a tutorial made for my photo editing app and it looks like the text isn't center launching on iPad... even if I change the background radius.

Captura de pantalla 2020-04-14 a las 19 44 57
quangctkm9207 commented 3 years ago

Thanks to a new PR from @kellyhuberty. I have just released a hot-fix version 0.7.3. It might help to solve this long-time issue that the text is not placed correctly in the view. Sorry again that I am not actively working on this project.