search

aromajoin / material-showcase-ios

✨ An elegant way to guide your beloved users in iOS apps - Material Showcase.
https://aromajoin.com/
Other
363 stars 128 forks source link

Fixes for positioning instruction view according to text height #126

Closed ezefire closed 4 years ago

ezefire commented 4 years ago

Fixes made to positioning instruction view using its height when instruction view is below the target.

Fixes made to positioning instruction view correctly in iPad when backgroundView is outer of the right side of the screen.

quangctkm9207 commented 4 years ago

Thank you @ezefire for your PR and time for this project. I really appreciate that. I am going to merge it then check if there is no issue, I will release a new version with your change as soon as possible.

ezefire commented 4 years ago

Hi Quang,

You are welcome. I do it with pleasure. Your lib is the unique lib of showcase for material design and it is very good and simple to use.

I do the fixes when i found them in my usages.

Kind regards, Cristian

El sáb., 18 abr. 2020 4:24, Quang Nguyen notifications@github.com escribió:

Merged #126 https://github.com/aromajoin/material-showcase-ios/pull/126 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aromajoin/material-showcase-ios/pull/126#event-3246455031, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDHRYSGAYFY376YVEDSRODRNEFMZANCNFSM4MKZC65A .

quangctkm9207 commented 4 years ago

Thank you @ezefire for your kind words and your time.

Best regards, Quang.