search

aromajoin / material-showcase-ios

✨ An elegant way to guide your beloved users in iOS apps - Material Showcase.
https://aromajoin.com/
Other
363 stars 128 forks source link

Property `targetHolderRadius` not found #36

Closed roycable closed 6 years ago

roycable commented 6 years ago

Strangely, I can't seem to set the targetHolderRadius value - tells me the property is not found.

targetTintColor and targetHolderColor isn't a problem, but just can't seem to see targetHolderRadius.

Objective C project, and installed material-showcase-ios via cocoapods.

I'll keep seeing what I can find, but pretty odd.

quangctkm9207 commented 6 years ago

It's strange. targetHolderRadius is defined here. https://github.com/aromajoin/material-showcase-ios/blob/696d3679a9d7eee2f57af74ccce8bee51f05b8d7/MaterialShowcase/MaterialShowcase.swift#L62

roycable commented 6 years ago

Yeah, I couldn't see anything strange with it.

To add to the mystery, I have the same issue with the following...

    showCase.aniRippleColor = [UIColor clearColor]; // this is ok

    showCase.aniComeInDuration = 0.0; // not found
    showCase.aniGoOutDuration = 0.0; // not found
    showCase.aniRippleScale = 1.5; // not found
    showCase.aniRippleAlpha = 0.2; // not found
propertiesnotfound

I have no issues when accessing those attributes in the Sample project.

NB: my temporary solution to having the holder radius 0.0 was to set

    showCase.targetHolderColor = [UIColor clearColor];
    showCase.aniRippleColor = [UIColor clearColor];
quangctkm9207 commented 6 years ago

I have not checked it in Objective-C, the problem maybe occurred when bridging API from Swift to Objective-C.

congnguyen91 commented 6 years ago

@quangctkm9207 Some class in switf. It should have a right default value :)

public var targetHolderRadius: CGFloat = 0

screen shot 2018-03-13 at 15 49 14 screen shot 2018-03-13 at 15 51 21

quangctkm9207 commented 6 years ago

@congnguyen91 Thank you for pointing it out. The latest PR from @Husseinhj Hu has fixed it. I will pump it to a new patch version on CocoaPods right now.

quangctkm9207 commented 6 years ago

Version 0.5.1 has just come out with this issue fix. Please check it on CocoaPods. I would like to close this issue. Have any issue? Reopening is always OK. :)