I made some changes to the tests. In particular, in the main test that you wrote I commented out the lines asserting that the property "IsGeometryShape" is mapped. You tell me, should that property get mapped? Double check, and figure out what the problem is if there is one. If there is no problem, and the property in fact should not be mapped, then you need to fix the tests to reflect that.
Also, I commented out a line where you check if a type is a record type or not and throw an exception. I don't know if this was doing anything important, but I removed it and all tests continued to pass, while one that was failing started to pass.
Fix up these two issues and that's about it from me, unless we want to do some refactoring/cleanup .
aromic1
commented
1 year ago
Related branch: review/11-9-2023
I made some changes to the tests. In particular, in the main test that you wrote I commented out the lines asserting that the property "IsGeometryShape" is mapped. You tell me, should that property get mapped? Double check, and figure out what the problem is if there is one. If there is no problem, and the property in fact should not be mapped, then you need to fix the tests to reflect that.
Also, I commented out a line where you check if a type is a record type or not and throw an exception. I don't know if this was doing anything important, but I removed it and all tests continued to pass, while one that was failing started to pass.
Fix up these two issues and that's about it from me, unless we want to do some refactoring/cleanup .