search

aromring / MAX30102_by_RF

Arduino C code for MAX30102 pulse oximetry sensor (MAXIM Integrated, Inc.)
166 stars 73 forks source link

Small change to facilitate compilation in a Linux box #39

Closed fexadom closed 6 months ago

fexadom commented 6 months ago

I am currently testing this code in an Arduino Nano 33 BLE (it has a Nordic nRF52480 MCU) and so far is working fine. Thank you very much for your work, it has been a life saver.

I am working on a Linux machine so I had a compilation problem with the "arduino.h" header file, the compiler could not find it. The easy fix is to change "arduino.h" to "Arduino.h" in every relevant file as the header name is actually "Arduino.h" and in case-sensitive Linux filesystems this matters. I saw in some of the closed issues that some users of this code encountered this problem so to help with a small contribution I propose this pull request that fixes this issue. This shouldn't have any negative effect on Windows systems.

sergiocntr commented 6 months ago

🥰

Il giorno gio 14 mar 2024 alle ore 16:12 Federico Domínguez < @.***> ha scritto:

I am currently testing this code in an Arduino Nano 33 BLE (it has a Nordic nRF52480 MCU) and so far is working fine. Thank you very much for your work, it has been a life saver.

I am working on a Linux machine so I had a compilation problem with the "arduino.h" header file, the compiler could not find it. The easy fix is to change "arduino.h" to "Arduino.h" in every relevant file as the header name is actually "Arduino.h" and in case-sensitive Linux filesystems this matters. I saw in some of the closed issues that some users of this code encountered this problem so to help with a small contribution I propose this pull request that fixes this issue. This shouldn't have any negative effect on Windows systems.

You can view, comment on, or merge this pull request online at:

https://github.com/aromring/MAX30102_by_RF/pull/39 Commit Summary

File Changes

(4 files https://github.com/aromring/MAX30102_by_RF/pull/39/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/aromring/MAX30102_by_RF/pull/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW4XQZN4HWUMVMJGWL3KCDYYG44ZAVCNFSM6AAAAABEWJTUSCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DMNRSGU3TONA . You are receiving this because you are subscribed to this thread.Message ID: @.***>