aronduby / hwp

0 stars 1 forks source link

Inline team rankings #12

Open aronduby opened 6 years ago

aronduby commented 6 years ago

Since we have the top 10 schools now we should add rankings to team names where available. Could be a FE JS thing or even a trans thing. Actually, the trans idea would be great... but we don't have consts for them, but I mean we basically do

aronduby commented 6 years ago

well if we do it an run time (either FE or BE) that could be weird because then if we're looking at something old it would show the latest ranking. Although, maybe that's ok? We totally could get away with some things auto-altering the team name (I think) or even doing an additional ranking query from team->ranking and using the related date to filter.

Oh man, so many options.

You could also argue the opposite that you would want the rankings to be based on what is happening right now because that is what information is pertant to the user going forward. Especially with the schedule, I feel like schedule would 100% have to be the current rankings. But, we (royal we) could definitely make the query scope take an optional date which so it could pull current or whatever it was when that date was setup.

But it'd probably be best to cache all this if we're doing it BE since that's a lot of stuff grabbing it so then query scope probably not the best, which brings me back to just doing current.

But we could definitely do something like what we do for the js player list and actually make a new js/json file when the rankings are updated which could make a FE solution really performant, and actually probably fairly easy (text search and injection). This could even be done in a way that handles current and past setup depending on what we want. Or, we could do some data attributes or something for if we want to switch between the two (current/timed) but we would probably want some sort of title or something specifying past/current.