search

aronson / discord-irc

Connects Discord and IRC channels by sending messages back and forth.
MIT License
4 stars 2 forks source link

Feature Request: Pluralkit message proxying #52

Closed KeiroD closed 10 months ago

KeiroD commented 10 months ago

So I know I was mentioning Pluralkit support in #29, but I think I'd like to expand on that request and explain what exactly I mean by this.

Can we get discord-irc to evaluate if a message is being sent by a user in a given role by Pluralkit or tupper? If the user is in that role, buffer the message internally inside the bot, and then if a delete event happens with a subsequent second message from a bot, do not display it. If there is no delete event, display the original message, as Pluralkit/Tupper currently does?

For example, see image:

moo

Some users have stated that seeing this is undesired and I don't know if it can be done. Theoretically it should be possible to do?

aronson commented 10 months ago

The freshly minted sha-aa39f29 has even more caching -- now all Discord entities are cached. Don't forsee any more updates related to caching.

KeiroD commented 10 months ago

Hah. Updated. No issues yet.

aronson commented 10 months ago

Released as 6.0.0

https://github.com/aronson/discord-irc/releases/tag/6.0.0

KeiroD commented 10 months ago

Beautiful, thanks! I will continue reporting issues as always.

KeiroD commented 10 months ago

Posting back update:

No role was implemented, but those with a system tag and not a PK tag of some sort are correctly being proxied. So even if one doesn't have a role, bot will proxy correctly regardless.

I think we're good!

aronson commented 10 months ago

Alright, closing this one out! Glad it's working great