Open tbergen1 opened 5 years ago
Hi Tom,
Thank you so much for your review! :) It was challenging but I'm happy that I managed to learn so much on Codeacademy working full time. I'll continue to learn with you guys!
Thanks again, Anna
wt., 3 wrz 2019 o 00:57 Tom Bergen notifications@github.com napisał(a):
Rubric Score Criteria 1: Valid Python Code
- Score Level: 4/4 (Exceeds Expectations)
- Comment(s): Your python code runs without any errors. Nice work!
Criteria 2: Implementation of Project Requirements
- Score Level: 4/4 (Exceeds Expectations)
- Comment(s): Your produces the full suite of functions and classes required by the spec. They are all called in the appropriate order as well. Great work!
Criteria 3: Software Architecture
- Score Level: 4/4 (Exceeds Expectations)
- Comment(s): Your code was separated into distinct classes and functions. Each were invoked with their own purposes. Good job with this!
Criteria 4: Uses Python Language Features
- Score Level: 4/4 (Exceeds Expectations)
- Comment(s): Your code leveraged python language features to solve tasks, which is great. Leveraging existing features to make your coding easier is always a good coding methodology. Good job!
Criteria 5: Produces Accurate Output
- Score Level: 4/4 (Exceeds Expectations)
- Comment(s): The code output is correct and properly formatted. The correct answer should have been Lily Trebuchet, but you might have arrived at Greg due to a small miscalculation somewhere in the process. It isn't a huge deal. Great job!
Overall Score: 20/20
Overall, you did a great job with this project. Your code ran without issues and produced a correct output, which was formatted properly. You structured your code well, separating it into distinct classes and functions each with their own purposes, which were executed in the appropriate order. Awesome work!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rossann9119/murder_mystery/issues/1?email_source=notifications&email_token=AI3U72IZRUUVSSDYZ772CHDQHWR5VA5CNFSM4ITAYRO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI3PK2Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AI3U72IENDNPFTL3D5RLO5TQHWR5VANCNFSM4ITAYROQ .
Rubric Score
Criteria 1: Valid Python Code
Criteria 2: Implementation of Project Requirements
Criteria 3: Software Architecture
Criteria 4: Uses Python Language Features
Criteria 5: Produces Accurate Output
Overall Score: 20/20
Overall, you did a great job with this project. Your code ran without issues and produced a correct output, which was formatted properly. You structured your code well, separating it into distinct classes and functions each with their own purposes, which were executed in the appropriate order. Awesome work!