search

arosspope / cipher-crypt

A cryptographic tomb of ciphers forgotten by time.
Apache License 2.0
42 stars 8 forks source link

Implement ADFGVX Cipher #25

Closed arosspope closed 6 years ago

avastmick commented 6 years ago

Happy to take this on. I was mindlessly re-doing what you've already done before I actually looked properly...

I was looking to port over picipher to Rust and had made some progress, I've dumped that now as it is just repeating what you've already done.

I've run your code through rustfmt and clippyand I'll also look to check coverage etc. before I PR.

Cheers

arosspope commented 6 years ago

Hey there, thanks for the input. I'll assign this issue to you if you don't mind. 😊

avastmick commented 6 years ago

That's great.

arosspope commented 6 years ago

Looks like I can't assign you from my end. If you don't mind, could you create a new issue detailing the changes you are making (ADFGVX, integrating rustfmt, etc.)?

avastmick commented 6 years ago

Okay - I'll do that in the incoming PR, and raise an issue on some of the integration issues that have come out of the implementation.

I think you can only assign someone to an issue if they are formally included as collaborators... I wouldn't bother. Have a look at the PR and see what you think.

avastmick commented 6 years ago

See PR #29