Closed arosspope closed 6 years ago
Hey there, thanks for the input. I'll assign this issue to you if you don't mind. 😊
That's great.
Looks like I can't assign you from my end. If you don't mind, could you create a new issue detailing the changes you are making (ADFGVX, integrating rustfmt, etc.)?
Okay - I'll do that in the incoming PR, and raise an issue on some of the integration issues that have come out of the implementation.
I think you can only assign someone to an issue if they are formally included as collaborators
... I wouldn't bother. Have a look at the PR and see what you think.
See PR #29
Happy to take this on. I was mindlessly re-doing what you've already done before I actually looked properly...
I was looking to port over picipher to Rust and had made some progress, I've dumped that now as it is just repeating what you've already done.
I've run your code through
rustfmt
andclippy
and I'll also look to check coverage etc. before I PR.Cheers