avastmick
commented
6 years ago Okay great. To be honest, this was my first Rust project, so apologies for the sloppiness in places. I'll fix up.
I'll have a look at the ColumnarTransposition code and the white space padding. In some tests I ran there was legitimate trailing whitespace. I understand why you included the padding, it makes the subsequent processing so much easier. But, unfortunately, I feel it does create downstream problems. I had a quick go a resolving, but I ran out of time (holidays here in China, and the kids are at home looking for things to do!).
Cheers
arosspope
Implementation of
ADFGVXCipher. Basic function is chain the existingPolybiusandColumnarTranspositionciphers.Tests included:
encrypt_messagedecrypt_messagewith_utf8invalid_key_phraseMost tests are delegated to those in
PolybiusandColumnarTranspositionciphers.Updated
.travis.ymlto includerustfmtcheck to ensure consistent code style. Build fails if developer has not formatted code, use:cargo +nightly fmtRan
Clippy-cargo +nightly clippyto lint existing code. I've fixed up most of the issues and it largely aligns with idiomatic styles.Merged in latest
masterand merged in my workingadfgvxbranch.Known issues:
ColumnarTranspositionpads with whitespace that leads to output that can include trailing whitespace. I think the cipher would not include whitespace, but without the padding, thedecryptfunction is harder as it is iterating over ragged column lengths that if unhandled with cause out of bounds errors.