open for design updates?

arp242 / goatcounter

Easy web analytics. No tracking of personal data.

https://www.goatcounter.com

Other

4.45k stars 179 forks source link

open for design updates? #732

Closed Tricked-dev closed 5 months ago

Tricked-dev commented 5 months ago

Hi i made a couple of changes to make the darkmode ui look a bit better and was wondering if these changes would be welcomed to be pr'ed to the main branch? (it wouild require a bit of refactoring on my part cause of the way ive done it currently but would be happy to)

arp242 commented 5 months ago

Yes! I've been getting people to actually design a dark more for ages.

All dark modes look unreadable to me – if a site has dark mode only then I either don't read/use it or fiddle with the CSS – for whatever reason my eyes just can't deal with it. So I can't really design that in any meaningful way. I already did all the technical stuff for it, just need someone to fill in some reasonable colours. See: https://github.com/arp242/goatcounter/issues/586#issuecomment-1287995673

Tricked-dev commented 5 months ago

do you like the blues? i feel like they are more readable than the purple in darkmode

arp242 commented 5 months ago

Sure, I'm fine with whatever – like I said, it all looks bad to me 🤷