emmt commented 8 months ago

I have noticed a list of potential issues:

Overlapping storage of members s and sl in toml_value_t. Fortunately, s is instantiated last and its value is correct for the caller but sl is not. Solution: remove member sl.
Untested memory allocation for z in toml_value_timestamp.
Potential memory leak with member z of the toml_timestamp_t structure if the caller just free(val.ts) and not free(val.ts.z).
Solution for the 2 latter points: make the z member of the toml_timestamp_t structure a char array of fixed size.

I can make a PR to solve these if you agree.

arp242 commented 8 months ago

I can make a PR to solve these if you agree.

Sure. I've been planning to audit this more in-depth, but I haven't really gotten around to it yet (partly because I didn't necessarily expect anyone to pay attention to this_.

arp242 commented 8 months ago

Oops, closed by accident.

emmt commented 8 months ago

arp242 / toml-c

Potential issues #2

3 shall fix these...