arp242 / uni

Query the Unicode database from the commandline, with good support for emojis
MIT License
790 stars 19 forks source link

Test failures #14

Closed DamienRobert closed 4 years ago

DamienRobert commented 4 years ago

With the new release (or current master), I get the following tests failures:

--- FAIL: TestPrint (0.11s)
    --- FAIL: TestPrint/[-q_p_OtherPunctuation] (0.00s)
        uni_test.go:144: wrong # of lines
            out:  593
            want: 588
    --- FAIL: TestPrint/[-q_p_Po] (0.00s)
        uni_test.go:144: wrong # of lines
            out:  593
            want: 588
    --- FAIL: TestPrint/[-q_p_all] (0.11s)
        uni_test.go:144: wrong # of lines
            out:  33797
            want: 32841
--- FAIL: TestEmoji (0.01s)
    --- FAIL: TestEmoji/[e_-tone_mediumlight_bride] (0.00s)
        uni_test.go:217: wrong output
            out:  []string{""}
            want: []string{"👰🏼"}
--- FAIL: TestAllEmoji (0.01s)
    uni_test.go:248: different length: want 3078, got 3195
    uni_test.go:252: 
FAIL
FAIL    arp242.net/uni  0.160s
ok      arp242.net/uni/isatty   0.004s
?       arp242.net/uni/terminal [no test files]
?       arp242.net/uni/unidata  [no test files]
FAIL
arp242 commented 4 years ago

Oh, I thought I had fixed that, but guess I forgot. Bride got replaced with "person with veil" (and man with veil, woman with veil), and the number are off because Unicode 13 added some stuff. I'll get 'round to fixing it eventually 😅

DamienRobert commented 4 years ago

I saw you updated the tests, thanks a lot!

Could you maybe made a minor 1.1.1 release? This way I can update the uni aur package : https://aur.archlinux.org/packages/uni/

arp242 commented 4 years ago

Oh, right; I didn't realize this was blocking anything 😅 Would have done it sooner otherwise!

arp242 commented 4 years ago

I pushed the v1.1.1 tag