search

arp242 / uni

Query the Unicode database from the commandline, with good support for emojis
MIT License
790 stars 19 forks source link

Fix warnings about uint32 conversion introduced by Go 1.15 #18

Closed muesli closed 3 years ago

muesli commented 3 years ago

Instead of directly converting the uint32 to a string, it converts to a rune first.

arp242 commented 3 years ago

Cheers, thanks

muesli commented 3 years ago

Thanks for merging @arp242!

Any chance we could see this in a new release in the near future? This is currently blocking packaging, for example in the AUR: https://aur.archlinux.org/packages/uni/

arp242 commented 3 years ago

I need to fix the new group:[..] query syntax; it works but the way it works is a bit weird (it worked weird before too, just in a different way).

It's just a harmless thing; the behaviour is the same and shouldn't prevent packaging.

muesli commented 3 years ago

You're right, it doesn't affect behavior of uni itself. It does however affect the output of go test which will now return with an exit code != 0, which in turn aborts the packaging process. I guess one could remove these checks, but it's not my package, so that's not my decision to make :smiley:

Either way: no rush really, just a heads up that it may be helpful to a bunch of users.

arp242 commented 3 years ago

You don't really need to run tests, and you can also disable it with the -vet flag to go test. I think @DamienRobert maintains the package (?)

This is one of those open source projects that I really made 100% for my own purposes, turns out some other people find it useful too and that's great, and I'm always happy to spend some time helping folks out and such, but it's really on a "best effort, whenever I feel like it basis" 😅 Just to set expectations.

At any rate, I looked a bit at it yesterday, and since it's mostly a matter of finding a syntax for this that I sufficiently like and didn't really have any inspiration for it 🙃 Since it's a backwards-incompatible change I'd rather get it right in one go instead doing a quick release and then changing it again later, and I'd like to think about other incompatible changes too if I'm releasing a v2 anyway.

muesli commented 3 years ago

@arp242 Of course you're right, but as mentioned, not my package :smile:

@DamienRobert: can you help out here?

DamienRobert commented 3 years ago

Sorry I missed the notification until now :-(

I just pushed a version to the aur that disable the checks until a new version is released.

arp242 commented 3 years ago

No worries; thank you :-)

muesli commented 3 years ago

Thanks @DamienRobert!

arp242 commented 3 years ago

I pushed release v2.0.0 FYI @DamienRobert

DamienRobert commented 3 years ago

Great, I updated the package!