Building fails due to error in zli dependency

arp242 / uni

Query the Unicode database from the commandline, with good support for emojis

MIT License

790 stars 19 forks source link

Building fails due to error in zli dependency #33

Closed chvp closed 2 years ago

chvp commented 2 years ago

I get the following error when trying to build this project:

# zgo.at/zli
../../go/pkg/mod/zgo.at/zli@v0.0.0-20220503115514-715dad1d8932/buildinfo_shim.go:25:3: cannot refer to unexported name fmt.fprintln

go version gives go version go1.17.9 linux/amd64.

arp242 commented 2 years ago

Oops, there was a typo in the Go <1.18 code, and never noticed as I have Go 1.18; should be fixed now, thanks!

chvp commented 2 years ago

Thanks for the quick fix. Any chance for a release including this? I'm trying to package your application for NixOS.

arp242 commented 2 years ago

Sure; I just tagged v2.5.1

arp242 commented 2 years ago

Ideally the package should be built with go build -ldflags "-X main.version=$VERSION" by the way; that way uni version will show the correct version. It's a minor thing though, but I noticed your nix package currently doesn't do it; but I don't know if that's just a "personal" package or if it's intended to be upstreamed(?) Just FYI anyway.

chvp commented 2 years ago

It was just a personal package to get things working, I will change it when upstreaming. Thanks!